Buy: Fix - Unhide EVM account when a new wallet is created via Buy Crypto#2172
Open
cmgustavo wants to merge 1 commit into
Open
Buy: Fix - Unhide EVM account when a new wallet is created via Buy Crypto#2172cmgustavo wants to merge 1 commit into
cmgustavo wants to merge 1 commit into
Conversation
…t state When adding a wallet via the Buy Crypto flow (e.g. USDC on Ethereum), the new wallet was created with hideWalletByAccount = false regardless of whether the parent EVM account was already hidden. This caused the token wallet to appear visible on the home screen while all other wallets in that account remained hidden. Fix: before pushing the new wallet to key.wallets in addWallet(), check evmAccountsInfo for the wallet's receiveAddress and inherit the hideAccount flag if present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When buying a token (e.g. USDC on Ethereum) whose parent EVM account was previously hidden, the newly created wallet would appear visible while the rest of the account (ETH, Polygon, Arbitrum, etc.) remained hidden, causing an inconsistent state on the home screen.
Fix: after addWallet() succeeds in the Buy Crypto flow, check if the created wallet's receive address belongs to a hidden EVM account and if so, unhide the entire account automatically.