improve docker-in-docker opts#1697
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Improves Docker‑in‑Docker reliability across
gvisorandrunc, hardens checkpoint create/restore/prune, tightens Python image build rules, and expands CPU‑only image build e2e tests. Adds graceful shutdown/cleanup, cancellable gRPC retries with backoff, quieter logs, clearer snapshot errors, and better killed‑process handling.Refactors
runtime.AddDockerInDockerCapabilities();runscprobes flags to set the packet‑write option; scheduler allows Docker‑enabled requests on bothruncandgvisor; sandbox pre‑stop kills inner containers and stopsdockerd/containerd; SDK runs inner Docker with host network/PID; Docker list helpers return stdout strings.ok; combined stream preserves buffered partial lines.IgnorePython; checkpoint pruning respects recent TTL/mtime and DB cutoff; repositoryGetOrCreateStubis workspace‑scoped and touchesupdated_at; cache manager starts the standby cache server immediately and stops registration on canceled contexts.Dockerfile;make build-testruns viauvwith the SDK project path and supports MODE filters.Bug Fixes
okand error messages; memory snapshots validateokand require a checkpoint ID; better cancellation classification during Docker startup.forceSymlinkcreates parent dirs; tar creation retries transient failures.HeadObject/CreateObjecthandle workspace storage availability correctly and avoid false existence checks when not using workspace storage.Written for commit a6313df. Summary will update on new commits.