add .maintainer.yaml with prReviewer.autoApprove#10
Merged
Conversation
Migrates pr-reviewer trust config from legacy .pr-reviewer.yaml to the shared .maintainer.yaml schema. Keeps .pr-reviewer.yaml until the new pr-reviewer image is deployed to prod; legacy file removed in follow-up.
There was a problem hiding this comment.
Based on my review, here's the analysis:
Diff Summary: Single file added - .maintainer.yaml with 15 lines (comments + config)
Review Findings:
The .maintainer.yaml file adds prReviewer.autoApprove: true configuration with inline documentation explaining:
- When
autoApprove: true, the verdict "approve" posts as an APPROVE (counts toward branch protection) - When false/absent, it demotes to COMMENT
- This replaces a legacy
.pr-reviewer.yamlfile
Concerns Assessment:
- Security: The
autoApprovesetting is explicitly documented in the file comments, explaining its effect on PR verdicts. The PR appears intentional. - YAML correctness: Structure is valid, simple boolean value under
prReviewerkey.
No automated checks failed (no precommit target in root Makefile, LICENSE file exists)
{
"verdict": "approve",
"summary": "Single-file PR adding .maintainer.yaml with prReviewer.autoApprove: true. The configuration is self-documenting with inline comments explaining the security implications (auto-approval counts toward branch protection). YAML structure is valid and correctly formatted.",
"comments": [],
"concerns_addressed": [
"security: autoApprove behavior documented in file comments — explains APPROVE vs COMMENT behavior",
"correctness: YAML structure is valid with simple prReviewer.autoApprove boolean"
]
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.maintainer.yamlwithprReviewer.autoApprove: true, migrating pr-reviewer trust config from the legacy.pr-reviewer.yaml..pr-reviewer.yamlfor now — the currently-deployed prod bot still reads it. Removed in a follow-up once the new pr-reviewer image is deployed.Test plan