fix: use base/base main branch for base-reth-node builds#181
Merged
Conversation
Revert base_reth_node_version from short commit SHA (1e4a8a7) back to 'main'. GitHub does not allow fetching arbitrary commit SHAs as refs, so `git fetch origin 1e4a8a7` fails during CI. Also simplify the checkout logic in build-base-reth-node.sh to match build-reth.sh — a direct `git checkout -f` is sufficient for both branch names and commit SHAs present in the cloned history.
Collaborator
✅ Heimdall Review Status
|
wlawt
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_reth_node_versionfrom short commit SHA (1e4a8a7) back tomainin bothversions.envand_build-binaries.yamlbuild-base-reth-node.shto matchbuild-reth.shRoot Cause
PR #175 changed
BASE_RETH_NODE_VERSIONfrommainto the short SHA1e4a8a7. GitHub does not allow fetching arbitrary commit SHAs as refs, sogit fetch origin 1e4a8a7fails during CI with:The commit exists in
base/base, but Git's protocol doesn't support fetching by raw SHA from GitHub remotes.Changes
clients/versions.env—BASE_RETH_NODE_VERSIONback tomain.github/workflows/_build-binaries.yaml— default input back tomainclients/build-base-reth-node.sh— removedgit fetch origin "$VERSION" || true+ fallback checkout; now uses a singlegit checkout -f "$VERSION"matching the pattern inbuild-reth.sh