test: add helm-unittest coverage for configmap and servicemonitor#337
Open
ChrisJBurns wants to merge 1 commit into
Open
test: add helm-unittest coverage for configmap and servicemonitor#337ChrisJBurns wants to merge 1 commit into
ChrisJBurns wants to merge 1 commit into
Conversation
42 tasks
ChrisJBurns
force-pushed
the
test/helm-unittest-configmap-servicemonitor
branch
from
63a24e5 to
1a1f728
Compare
Adds the first helm-unittest suites for the backstage chart (part of #335): the app-config ConfigMap and the ServiceMonitor, reusing the existing ci/*-values.yaml seeds. Runs them via a local pre-commit hook (with helm and the unittest plugin set up in the pre-commit workflow), bumps the chart to 2.8.2, regenerates the README, and adds a chart-level .helmignore so the tests dir is not packaged. Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
ChrisJBurns
force-pushed
the
test/helm-unittest-configmap-servicemonitor
branch
from
1a1f728 to
0a703a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First helm-unittest suites for the backstage chart, part of #335.
app-configConfigMap — only renders whenbackstage.appConfigis set, and embeds the config under theapp-config.yamlkeyTests run via a pre-commit hook and a new CI job (
helm unittest charts/backstage) on every PR.