Fix extraction of tarballs in py3.14#6304
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements extraction_filter support for archive extraction to align with Python 3.12 security features. The review feedback suggests restricting the filter application to tar archives to avoid compatibility issues with zip files and removing a redundant attribute assignment in the uncompress function that is already handled by the extract method.
Use fully_trusted_filter for extraction to restore previous method Closes: avocado-framework#6302 Signed-off-by: Arif Ali <arif-ali@ubuntu.com>
arif-ali
force-pushed
the
avocado-arif-py314-extract-trusted
branch
from
d18989d to
98d6104
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6304 +/- ##
==========================================
- Coverage 73.84% 72.31% -1.54%
==========================================
Files 206 206
Lines 22565 23260 +695
==========================================
+ Hits 16663 16820 +157
- Misses 5902 6440 +538 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
any thoughts on this at all, as we're facing this issue in our pipelines, and could really do with getting this resolved |
1 participant
Use fully_trusted_filter for extraction to restore previous method
Closes: #6302