refactor(appearance): enforce component style schemas#705
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a221afdf4c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
TorinAsakura
changed the title
…tract # Conflicts: # generators/appearance/src/appearance.generator.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f9bffe1f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70090f55ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Таска
Как проверять
Основной сценарий
button,inputиcheckbox.Действие: изменить сгенерированный
appearance.css.tsне по schema и запустить проверку schema.Ожидаемый результат: проверка падает на drift между schema и файлом.
Дополнительный сценарий
buttonиinputиспользуют runtime helper из@atls-ui-parts/theme.Действие: собрать генератор,
ui-parts/theme,button,inputиcheckbox.Ожидаемый результат: сборка проходит без runtime-зависимости
buttonиinputот@atls-ui-generators/appearance.Пруфы
yarn workspace @atls-ui-generators/appearance test unityarn workspace @atls-ui-generators/appearance buildyarn workspace @atls-ui-parts/theme buildyarn workspace @atls-ui-parts/button buildyarn workspace @atls-ui-parts/input buildyarn workspace @atls-ui-parts/checkbox buildyarn check