chore: qa fixes

Author: UdaySagar-Git

pyatlan/model/assets/core/alpha__d_q_rule.py

@@ -289,8 +289,8 @@ def updater(
         retrieved_column = search_result.alpha_dq_rule_base_column  # type: ignore[attr-defined]
         retrieved_alert_priority = search_result.alpha_dq_rule_alert_priority  # type: ignore[attr-defined]
         retrieved_row_scope_filtering_enabled = (
-            search_result.alpha_dq_rule_row_scope_filtering_enabled
-        )  # type: ignore[attr-defined]
+            search_result.alpha_dq_rule_row_scope_filtering_enabled  # type: ignore[attr-defined]
+        )
         retrieved_description = search_result.user_description
         retrieved_asset = search_result.alpha_dq_rule_base_dataset  # type: ignore[attr-defined]
         retrieved_template_rule_name = search_result.alpha_dq_rule_template_name  # type: ignore[attr-defined]
@@ -332,12 +332,18 @@ def updater(
             )
         )
 
+        final_compare_operator = (
+            validated_threshold_operator
+            or threshold_compare_operator
+            or retrieved_threshold_compare_operator
+        )
+
         config_arguments_raw = alpha_DQRule.Attributes._generate_config_arguments_raw(
             is_alert_enabled=True,
             custom_sql=custom_sql or retrieved_custom_sql,
             display_name=rule_name or retrieved_rule_name,
             dimension=dimension or retrieved_dimension,
-            compare_operator=validated_threshold_operator,
+            compare_operator=final_compare_operator,
             threshold_value=threshold_value or retrieved_threshold_value,
             threshold_unit=threshold_unit or retrieved_threshold_unit,
             column=retrieved_column,
@@ -351,7 +357,7 @@ def updater(
             name="",
             alpha_dq_rule_config_arguments=alpha_DQRuleConfigArguments(
                 alpha_dq_rule_threshold_object=alpha_DQRuleThresholdObject(
-                    alpha_dq_rule_threshold_compare_operator=validated_threshold_operator,
+                    alpha_dq_rule_threshold_compare_operator=final_compare_operator,
                     alpha_dq_rule_threshold_value=threshold_value
                     or retrieved_threshold_value,
                     alpha_dq_rule_threshold_unit=threshold_unit
@@ -1085,7 +1091,9 @@ class Attributes(DataQuality.Attributes):
 
         @staticmethod
         def _get_template_config_value(
-            config_value: str, property_name: str = None, value_key: str = "default"
+            config_value: str,
+            property_name: Optional[str] = None,
+            value_key: str = "default",
         ):
             if not config_value:
                 return None
@@ -1112,9 +1120,9 @@ def _validate_template_features(
                 alpha_DQRuleThresholdCompareOperator
             ] = None,
             asset: Optional[Asset] = None,
-        ) -> alpha_DQRuleThresholdCompareOperator:
+        ) -> Optional[alpha_DQRuleThresholdCompareOperator]:
             if not template_config or not template_config.get("config"):
-                return
+                return None
 
             config = template_config["config"]
 
@@ -1147,7 +1155,7 @@ def _validate_template_features(
             if rule_conditions:
                 allowed_rule_conditions = (
                     alpha_DQRule.Attributes._get_template_config_value(
-                        config.alpha_dq_rule_template_config_rule_conditions,
+                        config.alpha_dq_rule_template_config_rule_conditions or "",
                         None,
                         "enum",
                     )

pyatlan/model/dq_rule_conditions.py

@@ -46,13 +46,19 @@ def __init__(
             validate_required_fields(
                 ["min_value", "max_value"], [self.min_value, self.max_value]
             )
-            if self.min_value < 0 or self.max_value < 0:
+            if (self.min_value is not None and self.min_value < 0) or (
+                self.max_value is not None and self.max_value < 0
+            ):
                 raise ErrorCode.INVALID_PARAMETER_VALUE.exception_with_parameters(
                     f"min_value={self.min_value}, max_value={self.max_value}",
                     "min_value, max_value",
                     "non-negative integers",
                 )
-            if self.min_value > self.max_value:
+            if (
+                self.min_value is not None
+                and self.max_value is not None
+                and self.min_value > self.max_value
+            ):
                 raise ErrorCode.INVALID_PARAMETER_VALUE.exception_with_parameters(
                     f"min_value={self.min_value}, max_value={self.max_value}",
                     "min_value, max_value",
@@ -73,7 +79,7 @@ def __init__(
 
     def to_dict(self) -> Dict[str, Any]:
         """Convert the condition to a dictionary representation."""
-        result = {"type": self.type.value}
+        result: Dict[str, Any] = {"type": self.type.value}
 
         if self.type == alpha_dqRuleTemplateConfigRuleConditions.STRING_LENGTH_BETWEEN:
             result["value"] = {"minValue": self.min_value, "maxValue": self.max_value}
@@ -86,7 +92,7 @@ def to_dict(self) -> Dict[str, Any]:
 class DQRuleConditionsBuilder:
     """Builder for data quality rule conditions."""
 
-    def __init__(self):
+    def __init__(self) -> None:
         self._conditions: List[DQCondition] = []
 
     def add_condition(