feat: add tests for row scope filtering and rule conditions

Author: UdaySagar-Git

tests/unit/model/alpha__d_q_rule_test.py

@@ -4,10 +4,12 @@
 import pytest
 
 from pyatlan.model.assets import Column, Table, alpha_DQRule
+from pyatlan.model.dq_rule_conditions import DQRuleConditionsBuilder
 from pyatlan.model.enums import (
     alpha_DQDimension,
     alpha_DQRuleAlertPriority,
     alpha_DQRuleStatus,
+    alpha_dqRuleTemplateConfigRuleConditions,
     alpha_DQRuleThresholdCompareOperator,
     alpha_DQRuleThresholdUnit,
 )
@@ -39,6 +41,12 @@ def mock_client():
             }
         }
     )
+    config.alpha_dq_rule_template_config_rule_conditions = json.dumps(
+        {"enum": ["STRING_LENGTH_BETWEEN", "STRING_LENGTH_EQUAL"]}
+    )
+    config.alpha_dq_rule_template_advanced_settings = json.dumps(
+        {"alpha_dqRuleRowScopeFilteringEnabled": True}
+    )
 
     client.dq_template_config_cache.get_template_config.return_value = {
         "name": "Test Template",
@@ -383,6 +391,140 @@ def test_column_level_rule_creator_with_optional_parameters(mock_client):
     )
 
 
+def test_column_level_rule_creator_with_row_scope_filtering(mock_client):
+    asset = Table.ref_by_qualified_name(qualified_name=ALPHA_DQ_TABLE_QUALIFIED_NAME)
+    asset.alpha_asset_d_q_row_scope_filter_column_qualified_name = (
+        ALPHA_DQ_COLUMN_QUALIFIED_NAME
+    )
+    column = Column.ref_by_qualified_name(qualified_name=ALPHA_DQ_COLUMN_QUALIFIED_NAME)
+
+    dq_rule = alpha_DQRule.column_level_rule_creator(
+        client=mock_client,
+        rule_type=ALPHA_DQ_RULE_TYPE_COLUMN,
+        asset=asset,
+        column=column,
+        threshold_value=ALPHA_DQ_RULE_THRESHOLD_VALUE,
+        alert_priority=alpha_DQRuleAlertPriority.NORMAL,
+        row_scope_filtering_enabled=True,
+    )
+
+    assert dq_rule.alpha_dq_rule_alert_priority == alpha_DQRuleAlertPriority.NORMAL
+    assert dq_rule.alpha_dq_rule_status == alpha_DQRuleStatus.ACTIVE
+    assert dq_rule.alpha_dq_rule_row_scope_filtering_enabled is True
+    assert (
+        dq_rule.alpha_dq_rule_base_column_qualified_name
+        == ALPHA_DQ_COLUMN_QUALIFIED_NAME
+    )
+
+
+def test_column_level_rule_creator_with_rule_conditions(mock_client):
+    asset = Table.ref_by_qualified_name(qualified_name=ALPHA_DQ_TABLE_QUALIFIED_NAME)
+    column = Column.ref_by_qualified_name(qualified_name=ALPHA_DQ_COLUMN_QUALIFIED_NAME)
+
+    rule_conditions = (
+        DQRuleConditionsBuilder()
+        .add_condition(
+            type=alpha_dqRuleTemplateConfigRuleConditions.STRING_LENGTH_BETWEEN,
+            min_value=5,
+            max_value=50,
+        )
+        .build()
+    )
+
+    dq_rule = alpha_DQRule.column_level_rule_creator(
+        client=mock_client,
+        rule_type=ALPHA_DQ_RULE_TYPE_COLUMN,
+        asset=asset,
+        column=column,
+        threshold_value=ALPHA_DQ_RULE_THRESHOLD_VALUE,
+        alert_priority=alpha_DQRuleAlertPriority.NORMAL,
+        rule_conditions=rule_conditions,
+    )
+
+    assert dq_rule.alpha_dq_rule_alert_priority == alpha_DQRuleAlertPriority.NORMAL
+    assert dq_rule.alpha_dq_rule_status == alpha_DQRuleStatus.ACTIVE
+    assert (
+        dq_rule.alpha_dq_rule_config_arguments.alpha_dq_rule_config_rule_conditions
+        == rule_conditions
+    )
+    assert (
+        dq_rule.alpha_dq_rule_base_column_qualified_name
+        == ALPHA_DQ_COLUMN_QUALIFIED_NAME
+    )
+
+
+def test_validate_template_features_rule_conditions_not_supported(mock_client):
+    from pyatlan.errors import InvalidRequestError
+
+    config = Mock()
+    config.alpha_dq_rule_template_config_rule_conditions = None
+    config.alpha_dq_rule_template_advanced_settings = json.dumps({})
+
+    template_config = {
+        "name": "Test Template",
+        "qualified_name": "test/template/123",
+        "config": config,
+    }
+
+    mock_client.dq_template_config_cache.get_template_config.return_value = (
+        template_config
+    )
+
+    rule_conditions = (
+        DQRuleConditionsBuilder()
+        .add_condition(
+            type=alpha_dqRuleTemplateConfigRuleConditions.STRING_LENGTH_BETWEEN,
+            min_value=5,
+            max_value=50,
+        )
+        .build()
+    )
+
+    with pytest.raises(
+        InvalidRequestError,
+        match="Rule type 'Blank Count' does not support rule conditions",
+    ):
+        alpha_DQRule.Attributes._validate_template_features(
+            rule_type="Blank Count",
+            rule_conditions=rule_conditions,
+            row_scope_filtering_enabled=False,
+            template_config=template_config,
+            threshold_compare_operator=alpha_DQRuleThresholdCompareOperator.EQUAL,
+        )
+
+
+def test_validate_template_features_row_scope_filtering_not_supported(mock_client):
+    from pyatlan.errors import InvalidRequestError
+
+    config = Mock()
+    config.alpha_dq_rule_template_config_rule_conditions = json.dumps(
+        {"enum": ["STRING_LENGTH_BETWEEN"]}
+    )
+    config.alpha_dq_rule_template_advanced_settings = json.dumps({})
+
+    template_config = {
+        "name": "Test Template",
+        "qualified_name": "test/template/123",
+        "config": config,
+    }
+
+    mock_client.dq_template_config_cache.get_template_config.return_value = (
+        template_config
+    )
+
+    with pytest.raises(
+        InvalidRequestError,
+        match="Rule type 'Blank Count' does not support row scope filtering",
+    ):
+        alpha_DQRule.Attributes._validate_template_features(
+            rule_type="Blank Count",
+            rule_conditions=None,
+            row_scope_filtering_enabled=True,
+            template_config=template_config,
+            threshold_compare_operator=alpha_DQRuleThresholdCompareOperator.EQUAL,
+        )
+
+
 @pytest.mark.parametrize(
     "qualified_name, message",
     [

tests/unit/test_client.py

@@ -2767,3 +2767,25 @@ def test_add_dq_rule_schedule(mock_api_caller):
             )
             mock_save.assert_called_once_with(updated_table)
             assert result == mock_response
+
+
+def test_set_dq_row_scope_filter_column(mock_api_caller):
+    from pyatlan.model.response import AssetMutationResponse
+    from tests.unit.model.constants import (
+        ALPHA_DQ_COLUMN_QUALIFIED_NAME,
+        ALPHA_DQ_TABLE_QUALIFIED_NAME,
+    )
+
+    asset_client = AssetClient(mock_api_caller)
+    mock_response = Mock(spec=AssetMutationResponse)
+
+    with patch.object(asset_client, "save", return_value=mock_response) as mock_save:
+        result = asset_client.set_dq_row_scope_filter_column(
+            asset_type=Table,
+            asset_name="TestTable",
+            asset_qualified_name=ALPHA_DQ_TABLE_QUALIFIED_NAME,
+            row_scope_filter_column_qualified_name=ALPHA_DQ_COLUMN_QUALIFIED_NAME,
+        )
+
+        mock_save.assert_called_once()
+        assert result == mock_response