Add atError when kz=0 in gwig.c#1085
Merged
Merged
Conversation
Contributor
|
Unfortunately, your test is done after the element structure is allocated, and so it creates a memory leak: the structure will never be released. It should be moved inside Elem = (struct elem*)atMalloc(sizeof(struct elem));and with a (Sorry, I had no time to review yesterday…) |
Contributor
|
Oups I missed that...I went to fast on that one.... thanks @lfarv! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some safeguards in the gwig.c integrator following the discussion in: #1075
It raises an atError whenever a wiggler with kz=0 (in By or Bx) is called.
I am not sure whether I should call check_error() after atError(). What would you recommend?