Skip to content

fix: remove duplicate AsyncAPI spec loading in fromTemplate command#2118

Open
armorbreak001 wants to merge 1 commit into
asyncapi:masterfrom
armorbreak001:bounty/2017-duplicate-spec-loading
Open

fix: remove duplicate AsyncAPI spec loading in fromTemplate command#2118
armorbreak001 wants to merge 1 commit into
asyncapi:masterfrom
armorbreak001:bounty/2017-duplicate-spec-loading

Conversation

@armorbreak001

Copy link
Copy Markdown

Fixes #2017

Changes

  • Removed redundant second load(asyncapi) call in fromTemplate.ts
  • Reused the result from loadAsyncAPIInput(asyncapi) as the specification variable
  • Removed unused load import
  • The AsyncAPI file is now loaded and parsed only once, eliminating duplicate disk I/O and parsing overhead

Verification

  1. Run: asyncapi generate fromTemplate asyncapi.yaml @asyncapi/html-template -o out
  2. Verify generation works correctly (no functional change)
  3. Confirm only one file load occurs (add a console.log in load() to verify single invocation)

@changeset-bot

changeset-bot Bot commented Apr 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3f7799c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

[BUG] Duplicate AsyncAPI specification loading in fromTemplate.ts command (unnecessary double parsing)

1 participant