Conversation
….264 Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughTwo Helm charts (kubescape-operator and rapid7-operator) are updated with version bump to 1.40.1+private.1, kubescape-operator dependency updated to 1.40.1, nodeAgent image tag updated to v0.0.264, and configuration adjustments including imagePullSecret addition and kubevuln block removal. ChangesChart Version Synchronization & Configuration Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
charts/rapid7-operator/Chart.yaml (1)
26-29:⚠️ Potential issue | 🟠 Major | ⚡ Quick winSame
kubescape-operator1.40.1 dependency availability concern applies here.Same verification needed as in
charts/kubescape-operator/Chart.yaml— ensure1.40.1is available inhttps://kubescape.github.io/helm-charts/before merging and deploying.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@charts/rapid7-operator/Chart.yaml` around lines 26 - 29, The Chart.yaml lists a dependency on kubescape-operator version 1.40.1 which may not exist in the kubescape helm repo; verify that version 1.40.1 is published at https://kubescape.github.io/helm-charts/ and if it is not, update the dependency version in the dependencies block (name: kubescape-operator, version: 1.40.1, repository: "https://kubescape.github.io/helm-charts/") to an available release or pin to a known good version, then run helm repo update and helm dependency update to refresh Chart.lock before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/kubescape-operator/Chart.yaml`:
- Around line 26-29: The Chart.yaml dependency pins kubescape-operator to an
unpublished version (version: 1.40.1) which will break helm dependency
update/install; open Chart.yaml, locate the dependencies block for the
dependency with name: kubescape-operator and change the version field to a
published release (for example 1.29.10 or any version that exists in the
upstream repository "https://kubescape.github.io/helm-charts/"), then run helm
repo update and helm dependency update to verify the chart can be fetched.
---
Duplicate comments:
In `@charts/rapid7-operator/Chart.yaml`:
- Around line 26-29: The Chart.yaml lists a dependency on kubescape-operator
version 1.40.1 which may not exist in the kubescape helm repo; verify that
version 1.40.1 is published at https://kubescape.github.io/helm-charts/ and if
it is not, update the dependency version in the dependencies block (name:
kubescape-operator, version: 1.40.1, repository:
"https://kubescape.github.io/helm-charts/") to an available release or pin to a
known good version, then run helm repo update and helm dependency update to
refresh Chart.lock before merging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 724c6422-966d-421e-ab5a-a6a97b365592
⛔ Files ignored due to path filters (2)
charts/kubescape-operator/tests/__snapshot__/snapshot_test.yaml.snapis excluded by!**/*.snapcharts/rapid7-operator/tests/__snapshot__/snapshot_test.yaml.snapis excluded by!**/*.snap
📒 Files selected for processing (4)
charts/kubescape-operator/Chart.yamlcharts/kubescape-operator/values.yamlcharts/rapid7-operator/Chart.yamlcharts/rapid7-operator/values.yaml
There was a problem hiding this comment.
Pull request overview
This PR updates the two wrapper charts (armosec-kubescape-operator and rapid7-operator) to consume kubescape-operator chart version 1.40.1, while also bumping the overridden node-agent image tag to v0.0.264 and refreshing the rendered snapshot outputs to match the new upstream manifests.
Changes:
- Bump chart
version/appVersionand dependencykubescape-operatorversion to1.40.1for both wrapper charts. - Update
nodeAgent.image.tagoverride tov0.0.264and remove the explicitkubevuln.image.tagoverride from wrapper values. - Update helm snapshot test outputs to reflect upstream 1.40.1 rendered resources/config.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/rapid7-operator/Chart.yaml | Bumps wrapper chart + dependency version to 1.40.1. |
| charts/rapid7-operator/values.yaml | Updates node-agent tag override; removes kubevuln tag override. |
| charts/rapid7-operator/tests/snapshot/snapshot_test.yaml.snap | Refreshes rendered snapshot output for upstream 1.40.1. |
| charts/kubescape-operator/Chart.yaml | Bumps wrapper chart + dependency version to 1.40.1. |
| charts/kubescape-operator/values.yaml | Updates node-agent tag override; removes kubevuln tag override. |
| charts/kubescape-operator/tests/snapshot/snapshot_test.yaml.snap | Refreshes rendered snapshot output for upstream 1.40.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Summary by CodeRabbit