feat: Support video transcript chunking in the Arm Knowledge Base#100
Closed
NeethuESim wants to merge 3 commits into
Closed
feat: Support video transcript chunking in the Arm Knowledge Base#100NeethuESim wants to merge 3 commits into
NeethuESim wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for transcript-backed video sources in the embedding-generation pipeline by introducing an optional Transcript Source URL column in the sources CSV. When provided, chunk generation fetches/chunks the transcript content while preserving the primary URL as the user-facing retrieval link.
Changes:
- Extend sources CSV read/load/save logic to include
Transcript Source URL/transcript_source_url. - Add transcript-aware chunking path (
create_transcript_chunks) and plumb transcript URLs throughmain(). - Update documentation and expand tests to cover transcript URL persistence + transcript chunking behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| embedding-generation/generate-chunks.py | Adds transcript URL handling in CSV flows and transcript-backed chunk creation. |
| embedding-generation/tests/test_generate_chunks.py | Updates CSV expectations and adds tests for transcript persistence + transcript chunking dispatch. |
| embedding-generation/README.md | Documents the new CSV column and how transcript-backed sources behave. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Closing this PR for now. Will open another after finishing https://jira.arm.com/browse/STESOL-542 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Ticket - https://jira.arm.com/browse/STESOL-526