[ATFE] Introduce seperate multilib groups for base and minor variants.#881
Open
simpal01 wants to merge 2 commits into
Open
[ATFE] Introduce seperate multilib groups for base and minor variants.#881simpal01 wants to merge 2 commits into
simpal01 wants to merge 2 commits into
Conversation
This change introduces separate multilib groups so minor library variants can be selected alongside the base library variant. This patch: 1. Replaces the stdlibs group with base_stdlibs for base library variants. 2. Adds independent exclusive groups for overlay layers: - string_minor_libs - startup_libs 3. Updates multilib YAML generation to emit each variant’s configured group. 4. Restricts header include directory optimisation to base_stdlibs With this structure, the resolver can select one base variant and one matching variant from each overlay group at the same time, allowing the minor library variants to stay with the selected base variant.
voltur01
reviewed
Jun 11, 2026
| # Make an exclusive group for library variants, to make sure we don't | ||
| # accidentally include two or more variants at once. | ||
| # Make the main library selection exclusive, to make sure we don't | ||
| # accidentally include two or more base variants at once.But allow |
Contributor
There was a problem hiding this comment.
Suggested change
| # accidentally include two or more base variants at once.But allow | |
| # accidentally include two or more base variants at once. But allow |
vhscampos
reviewed
Jun 25, 2026
| string(APPEND multilib_yaml_content " - ${parent_dir_name}/include\n") | ||
| endif() | ||
| string(APPEND multilib_yaml_content " Group: stdlibs\n") | ||
| string(APPEND multilib_yaml_content " ${variant_group}\n") |
Contributor
There was a problem hiding this comment.
You dropped the "Group: " part of the string. Double check if it's intended
Contributor
Author
There was a problem hiding this comment.
It was included in my local patch along with all the other changes. When I manually split it into multiple patches, it was unintentionally dropped. I’ve added it back now. Good catch!
Comment on lines
+37
to
+41
| - Name: base_stdlibs | ||
| Type: Exclusive | ||
| - Name: string_minor_libs | ||
| Type: Exclusive | ||
| - Name: startup_libs |
Contributor
There was a problem hiding this comment.
I'm not really convinced about these names. Naming is hard :)
I'd call them base_libs, string_libs and startup_libs. But ask for more opinions
…ariants. 1. Missed the "Group:" part. 2. Renamed the groups as requested. 3. Added a space in the comment description.
vhscampos
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces separate multilib groups so minor library variants can be selected alongside the base library variant.
This patch:
This allows one base variant and one matching variant from each layering group at the same time, allowing the minor library variants to stay with the selected base variant.