Move the VminitdCore library to the top-level package#742
Open
dkovba wants to merge 4 commits into
Open
Conversation
dcantah
reviewed
May 19, 2026
| path: "vminitd/Sources/LCShim" | ||
| ), | ||
| .target( | ||
| name: "Cgroup", |
Member
There was a problem hiding this comment.
I'm not super happy about this as I wanted to give the API we expose a better exploration, but if this is what we need to do for now that's okay with me.
Contributor
Author
There was a problem hiding this comment.
Agreed, we can trim what doesn't need to cross the package boundary.
dcantah
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External Swift Package Manager consumers can only see products declared in the top-level
Package.swift. TheVminitdCorelibrary was declared inside thevminitdsubpackage, so it was impossible to build a customvminitdagainst it via a URL dependency oncontainerization. This change moves theVminitdCoreto the top-levelPackage.swift.