chore: removing add_command from bridge#555
Closed
KazuCocoa wants to merge 6 commits into
Closed
Conversation
KazuCocoa
commented
May 18, 2024
|
|
||
| def add_command(method:, url:, name:, &block) | ||
| ::Appium::Logger.info "Overriding the method '#{name}' for '#{url}'" if @available_commands.key? name | ||
| # def add_command(method:, url:, name:, &block) |
Member
Author
There was a problem hiding this comment.
here can be later. Firstly we could use the bridge function to other existing methods
Contributor
|
@KazuCocoa I have some free time in my hands now, can I help with this or with anything else? |
Member
Author
|
No much actively modifying this right now, but it would be nice to drop add_command implementation form this lib, and use https://github.com/search?q=repo%3ASeleniumHQ%2Fselenium%20add_command&type=code |
Contributor
|
@KazuCocoa nice I will give it a try :) |
Contributor
|
Should this be closed because of #671 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still need to do something in the driver layer, but basic bridge layer is probably can do with selenium 4.21