[#2753] fix(spark): ignore removed failed blocks#2754
Open
zuston wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix NPE by better handling removed blocks
Why are the changes needed?
getFailedBlockIds()returned a live key set from a concurrent map. After one thread got a failed block id, another thread could clear that block’s failed state after the block was resent successfully. ThengetFailedBlockStatus(blockId)returned null, and the resend logic later accessed it, causing aNullPointerException.fix #2753
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test