Skip to content

chore: ignore vendored and generated paths in Codecov#5187

Merged
Yicong-Huang merged 1 commit into
apache:mainfrom
Yicong-Huang:chore/codecov-ignore-vendored
May 24, 2026
Merged

chore: ignore vendored and generated paths in Codecov#5187
Yicong-Huang merged 1 commit into
apache:mainfrom
Yicong-Huang:chore/codecov-ignore-vendored

Conversation

@Yicong-Huang
Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

codecov.yml already ignores generated Python protobuf, build output, and test files. .licenserc.yaml exempts a third set of paths from its header check on the basis that we don't maintain them — vendored MIT code and the frontend protobuf TS codegen. Their coverage figures carry no signal about Texera's test quality, but they sit in the project denominator and drag the headline percentage down. Mirror those entries in Codecov's ignore list so the rollup reflects only code we own.

Any related issues, documentation, discussions?

Closes #5186. The ignored paths match the corresponding paths-ignore entries in .licenserc.yaml.

How was this PR tested?

codecov.yml parses as valid YAML; every concrete path in the new entries resolves to a real file on main. Codecov re-evaluates the config on the next upload to main.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Opus 4.7

The repo's `.licenserc.yaml` already exempts three classes of file from
its header check because we don't maintain them — vendored MIT code and
generated protobuf TypeScript. Their coverage figures carry no signal
about Texera's test quality, but they sit in the project denominator
and drag the headline percentage down. Mirror those entries in
`codecov.yml`'s `ignore` list so the rollup reflects only code we own.

Categories added: vendored kjetland JSON schema generator, vendored
ngx-formly type wrappers, vendored monaco-languageclient files, and the
frontend protobuf TS codegen output (mirror of the existing Python
proto rule).

Closes apache#5186
@github-actions github-actions Bot added the ci changes related to CI label May 24, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.54%. Comparing base (afb29e7) to head (feb4b96).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5187      +/-   ##
============================================
+ Coverage     43.91%   44.54%   +0.63%     
  Complexity     2218     2218              
============================================
  Files          1049     1042       -7     
  Lines         40578    39989     -589     
  Branches       4327     4260      -67     
============================================
- Hits          17818    17813       -5     
+ Misses        21640    21059     -581     
+ Partials       1120     1117       -3     
Flag Coverage Δ
access-control-service 39.53% <ø> (ø)
agent-service 33.76% <ø> (ø)
amber 45.74% <ø> (+1.57%) ⬆️
computing-unit-managing-service 0.00% <ø> (ø)
config-service 0.00% <ø> (ø)
file-service 32.18% <ø> (ø)
frontend 35.74% <ø> (+0.08%) ⬆️
python 90.50% <ø> (ø)
workflow-compiling-service 56.81% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Yicong-Huang Yicong-Huang requested a review from aglinxinyuan May 24, 2026 22:07
@Yicong-Huang Yicong-Huang added this pull request to the merge queue May 24, 2026
Merged via the queue into apache:main with commit 0ebab77 May 24, 2026
25 checks passed
@Yicong-Huang Yicong-Huang deleted the chore/codecov-ignore-vendored branch May 24, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore vendored and generated code in Codecov coverage

3 participants