fix(amber): round-trip LogicalLink operator identities#5175
Open
officialasishkumar wants to merge 1 commit into
Open
fix(amber): round-trip LogicalLink operator identities#5175officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5175 +/- ##
=========================================
Coverage 43.65% 43.66%
Complexity 2219 2219
=========================================
Files 1049 1049
Lines 40572 40606 +34
Branches 4324 4332 +8
=========================================
+ Hits 17713 17731 +18
- Misses 21767 21775 +8
- Partials 1092 1100 +8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
LogicalLinkhad an asymmetric Jackson contract: frontend-saved workflow JSON with string-shaped operator ids ("fromOpId": "op-A") deserialized correctly, but JSON emitted by the productionobjectMapperserializedOperatorIdentityas an object ("fromOpId": {"id": "op-A"}), which the only@JsonCreatorpath could not read back.This PR changes the Jackson creator in both
LogicalLinkmodels to accept either shape:objectMapper.writeValueAsStringThe existing Scala string constructor is kept for direct callers, and the existing null/empty/self-loop validation in the Amber model continues to run through the primary constructor.
Any related issues, documentation, discussions?
Closes #5042.
How was this PR tested?
Validated locally with a temporary Postgres container loaded with the same DDL files used by CI for JOOQ generation.
Result:
LogicalLinkSpec18 passed,WorkflowCompilationResourceSpec3 passed.Result: passed.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)