refactor(config): inject Spring's ObjectMapper into JsonResponseParser

Replace the static new ObjectMapper() with Spring's auto-configured
ObjectMapper bean injected via constructor. Use MediaType.APPLICATION_JSON_VALUE
for the content type constant instead of a raw string literal.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>

Author: adityamparikh

src/main/java/org/apache/solr/mcp/server/config/JsonResponseParser.java

@@ -29,6 +29,7 @@
 import org.apache.solr.common.SolrException;
 import org.apache.solr.common.util.NamedList;
 import org.apache.solr.common.util.SimpleOrderedMap;
+import org.springframework.http.MediaType;
 
 /**
  * SolrJ {@link ResponseParser} that requests JSON wire format ({@code wt=json})
@@ -67,7 +68,11 @@
  */
 class JsonResponseParser extends ResponseParser {
 
-	private static final ObjectMapper MAPPER = new ObjectMapper();
+	private final ObjectMapper mapper;
+
+	JsonResponseParser(ObjectMapper mapper) {
+		this.mapper = mapper;
+	}
 
 	@Override
 	public String getWriterType() {
@@ -76,13 +81,13 @@ public String getWriterType() {
 
 	@Override
 	public String getContentType() {
-		return "application/json; charset=UTF-8";
+		return MediaType.APPLICATION_JSON_VALUE;
 	}
 
 	@Override
 	public NamedList<Object> processResponse(InputStream body, String encoding) {
 		try {
-			return toNamedList(MAPPER.readTree(body));
+			return toNamedList(mapper.readTree(body));
 		} catch (IOException e) {
 			throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "Failed to parse Solr JSON response", e);
 		}
@@ -91,7 +96,7 @@ public NamedList<Object> processResponse(InputStream body, String encoding) {
 	@Override
 	public NamedList<Object> processResponse(Reader reader) {
 		try {
-			return toNamedList(MAPPER.readTree(reader));
+			return toNamedList(mapper.readTree(reader));
 		} catch (IOException e) {
 			throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "Failed to parse Solr JSON response", e);
 		}

src/main/java/org/apache/solr/mcp/server/config/SolrConfig.java

@@ -16,6 +16,7 @@
  */
 package org.apache.solr.mcp.server.config;
 
+import com.fasterxml.jackson.databind.ObjectMapper;
 import java.util.concurrent.TimeUnit;
 import org.apache.solr.client.solrj.SolrClient;
 import org.apache.solr.client.solrj.impl.Http2SolrClient;
@@ -168,8 +169,8 @@ public class SolrConfig {
 	 * @see SolrConfigurationProperties#url()
 	 */
 	@Bean
-	JsonResponseParser jsonResponseParser() {
-		return new JsonResponseParser();
+	JsonResponseParser jsonResponseParser(ObjectMapper objectMapper) {
+		return new JsonResponseParser(objectMapper);
 	}
 
 	@Bean

src/test/java/org/apache/solr/mcp/server/config/SolrConfigTest.java

@@ -18,6 +18,7 @@
 
 import static org.junit.jupiter.api.Assertions.*;
 
+import com.fasterxml.jackson.databind.ObjectMapper;
 import org.apache.solr.client.solrj.SolrClient;
 import org.apache.solr.client.solrj.impl.Http2SolrClient;
 import org.apache.solr.mcp.server.TestcontainersConfiguration;
@@ -81,7 +82,7 @@ void testUrlNormalization(String inputUrl, String expectedUrl) {
 		SolrConfig solrConfig = new SolrConfig();
 
 		// Test URL normalization
-		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser());
+		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser(new ObjectMapper()));
 		assertNotNull(client);
 
 		var httpClient = assertInstanceOf(Http2SolrClient.class, client);
@@ -101,7 +102,7 @@ void testUrlWithoutTrailingSlash() {
 		SolrConfigurationProperties testProperties = new SolrConfigurationProperties("http://localhost:8983");
 		SolrConfig solrConfig = new SolrConfig();
 
-		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser());
+		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser(new ObjectMapper()));
 		Http2SolrClient httpClient = (Http2SolrClient) client;
 
 		// Should add trailing slash and solr path
@@ -120,7 +121,7 @@ void testUrlWithTrailingSlashButNoSolrPath() {
 		SolrConfigurationProperties testProperties = new SolrConfigurationProperties("http://localhost:8983/");
 		SolrConfig solrConfig = new SolrConfig();
 
-		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser());
+		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser(new ObjectMapper()));
 		Http2SolrClient httpClient = (Http2SolrClient) client;
 
 		// Should add solr path to existing trailing slash
@@ -139,7 +140,7 @@ void testUrlWithSolrPathButNoTrailingSlash() {
 		SolrConfigurationProperties testProperties = new SolrConfigurationProperties("http://localhost:8983/solr");
 		SolrConfig solrConfig = new SolrConfig();
 
-		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser());
+		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser(new ObjectMapper()));
 		Http2SolrClient httpClient = (Http2SolrClient) client;
 
 		// Should add trailing slash
@@ -158,7 +159,7 @@ void testUrlAlreadyProperlyFormatted() {
 		SolrConfigurationProperties testProperties = new SolrConfigurationProperties("http://localhost:8983/solr/");
 		SolrConfig solrConfig = new SolrConfig();
 
-		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser());
+		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser(new ObjectMapper()));
 		Http2SolrClient httpClient = (Http2SolrClient) client;
 
 		// Should remain unchanged