refactor(config): make JsonResponseParser a Spring Bean

Extract JsonResponseParser instantiation into a dedicated @bean method
so it can be injected as a dependency into solrClient(), making the
wiring explicit and enabling overriding in tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>

Author: adityamparikh

src/main/java/org/apache/solr/mcp/server/config/SolrConfig.java

@@ -168,7 +168,12 @@ public class SolrConfig {
 	 * @see SolrConfigurationProperties#url()
 	 */
 	@Bean
-	SolrClient solrClient(SolrConfigurationProperties properties) {
+	JsonResponseParser jsonResponseParser() {
+		return new JsonResponseParser();
+	}
+
+	@Bean
+	SolrClient solrClient(SolrConfigurationProperties properties, JsonResponseParser jsonResponseParser) {
 		String url = properties.url();
 
 		// Ensure URL is properly formatted for Solr
@@ -188,7 +193,7 @@ SolrClient solrClient(SolrConfigurationProperties properties) {
 
 		// Use with explicit base URL; JSON wire format replaces the JavaBin default
 		return new Http2SolrClient.Builder(url).withConnectionTimeout(CONNECTION_TIMEOUT_MS, TimeUnit.MILLISECONDS)
-				.withIdleTimeout(SOCKET_TIMEOUT_MS, TimeUnit.MILLISECONDS).withResponseParser(new JsonResponseParser())
+				.withIdleTimeout(SOCKET_TIMEOUT_MS, TimeUnit.MILLISECONDS).withResponseParser(jsonResponseParser)
 				.build();
 	}
 }

src/test/java/org/apache/solr/mcp/server/config/SolrConfigTest.java

@@ -81,7 +81,7 @@ void testUrlNormalization(String inputUrl, String expectedUrl) {
 		SolrConfig solrConfig = new SolrConfig();
 
 		// Test URL normalization
-		SolrClient client = solrConfig.solrClient(testProperties);
+		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser());
 		assertNotNull(client);
 
 		var httpClient = assertInstanceOf(Http2SolrClient.class, client);
@@ -101,7 +101,7 @@ void testUrlWithoutTrailingSlash() {
 		SolrConfigurationProperties testProperties = new SolrConfigurationProperties("http://localhost:8983");
 		SolrConfig solrConfig = new SolrConfig();
 
-		SolrClient client = solrConfig.solrClient(testProperties);
+		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser());
 		Http2SolrClient httpClient = (Http2SolrClient) client;
 
 		// Should add trailing slash and solr path
@@ -120,7 +120,7 @@ void testUrlWithTrailingSlashButNoSolrPath() {
 		SolrConfigurationProperties testProperties = new SolrConfigurationProperties("http://localhost:8983/");
 		SolrConfig solrConfig = new SolrConfig();
 
-		SolrClient client = solrConfig.solrClient(testProperties);
+		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser());
 		Http2SolrClient httpClient = (Http2SolrClient) client;
 
 		// Should add solr path to existing trailing slash
@@ -139,7 +139,7 @@ void testUrlWithSolrPathButNoTrailingSlash() {
 		SolrConfigurationProperties testProperties = new SolrConfigurationProperties("http://localhost:8983/solr");
 		SolrConfig solrConfig = new SolrConfig();
 
-		SolrClient client = solrConfig.solrClient(testProperties);
+		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser());
 		Http2SolrClient httpClient = (Http2SolrClient) client;
 
 		// Should add trailing slash
@@ -158,7 +158,7 @@ void testUrlAlreadyProperlyFormatted() {
 		SolrConfigurationProperties testProperties = new SolrConfigurationProperties("http://localhost:8983/solr/");
 		SolrConfig solrConfig = new SolrConfig();
 
-		SolrClient client = solrConfig.solrClient(testProperties);
+		SolrClient client = solrConfig.solrClient(testProperties, new JsonResponseParser());
 		Http2SolrClient httpClient = (Http2SolrClient) client;
 
 		// Should remain unchanged