Skip to content

support report the index of servicecomb_kie_config_count to prometheus#315

Open
tornado-ssy wants to merge 1 commit into
apache:devfrom
tornado-ssy:dev-totalConfig
Open

support report the index of servicecomb_kie_config_count to prometheus#315
tornado-ssy wants to merge 1 commit into
apache:devfrom
tornado-ssy:dev-totalConfig

Conversation

@tornado-ssy

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread server/config/struct.go

type MetricObject struct {
Domain string `yaml:"domain"`
Project string `yaml:"project"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要配置,这些通过环境变量控制即可

"github.com/apache/servicecomb-kie/server/datasource"
)

const ReportInterval = 15

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个需要可配置

if m.Project == "" {
m.Project = "default"
}
ReportTicker := time.NewTicker(ReportInterval * time.Second)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

局部变量命名大写开头不规范

@@ -0,0 +1,57 @@
package metric

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是server/metrics包

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants