HDDS-14954. Add logging and metric for SCM safemode duration.#10018
Draft
sadanand48 wants to merge 3 commits intoapache:masterfrom
Draft
HDDS-14954. Add logging and metric for SCM safemode duration.#10018sadanand48 wants to merge 3 commits intoapache:masterfrom
sadanand48 wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
Thanks for adding this @sadanand48. Let's add new safemode metrics to the safemode dashboard as well. |
Contributor
sreejasahithi
left a comment
sreejasahithi
left a comment
There was a problem hiding this comment.
Thanks @sadanand48 for working on this.
Could you please add the Grafana dashboard screenshots to the PR description.
Comment on lines
+62
to
+68
| @Metric("Wall-clock time (ms) SCM spent in safe mode for the last exit") | ||
| private MutableGaugeLong scmSafeModeExitDurationMs; | ||
| @Metric("Duration (ms) of the last Ratis container safe mode rule incremental refresh") | ||
| private MutableGaugeLong lastRatisContainerSafeModeRuleRefreshDurationMs; | ||
| @Metric("Duration (ms) of the last EC container safe mode rule incremental refresh") | ||
| private MutableGaugeLong lastEcContainerSafeModeRuleRefreshDurationMs; | ||
|
|
Contributor
There was a problem hiding this comment.
Could you please add test for these metrics. Since the existing test infrastructure already sets up everything needed, coverage can be added with just a line or two in existing tests rather than writing new ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a metric for :
We need this because in large clusters it is observed that refresh takes a lot of time. This can be used for monitoring.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14954