Skip to content

Warn checksum policy should not fail if no checksums #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cstamas wants to merge 1 commit into from
+10 −0
Closed

Warn checksum policy should not fail if no checksums #1921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/WarnChecksumPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@ final class WarnChecksumPolicy extends AbstractChecksumPolicy {
super(resource);
}

@Override
public void onNoMoreChecksums() throws ChecksumFailureException {
logger.warn(
"No checksums available to validate integrity of download from {}{}",
resource.getRepositoryUrl(),
resource.getResourceName());
}

@Override
public boolean onTransferChecksumFailure(ChecksumFailureException exception) {
logger.warn(
Expand Down
2 changes: 2 additions & 0 deletions ...-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/WarnChecksumPolicyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.eclipse.aether.transfer.ChecksumFailureException;
import org.eclipse.aether.transfer.TransferResource;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.*;
Expand Down Expand Up @@ -77,6 +78,7 @@ void testOnChecksumError() throws Exception {
policy.onChecksumError("SHA-1", ChecksumKind.REMOTE_EXTERNAL, exception);
}

@Disabled("Disabled as part of https://github.com/apache/maven-resolver/issues/1920")
@Test
void testOnNoMoreChecksums() {
try {
Expand Down
Loading