Harden release + verify scripts for SVN upload and local artifact dirs#1641
Open
skrawcz wants to merge 1 commit into
Open
Harden release + verify scripts for SVN upload and local artifact dirs#1641skrawcz wants to merge 1 commit into
skrawcz wants to merge 1 commit into
Conversation
These bugs surfaced while cutting the sub-package RC1 release. apache_release_helper.py: - create_release_artifacts: return absolute artifact paths. The function chdir's into the package working_dir to build, but svn_upload runs from the repo root, so the previously-returned relative paths failed to resolve (svn import 'No such file or directory'). - svn_upload: tolerate an already-existing SVN RC directory so a re-run after a partial/failed upload can resume importing files instead of aborting on 'svn mkdir'. verify-sub-packages/*.sh: - Resolve ARTIFACTS_DIR to an absolute path right after acquisition. The functional step does 'cd /tmp' (to avoid the local checkout shadowing venv packages), which broke a relative local artifacts dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These bugs surfaced while cutting the apache-hamilton-{sdk,ui,lsp,contrib} RC1 release.
scripts/apache_release_helper.pyAbsolute artifact paths.
create_release_artifactschdir's into the packageworking_dirto build, butsvn_uploadruns from the repo root. The previously-returned relative paths then failed to resolve, producing:Now returns absolute paths so the import works regardless of CWD.
Resumable SVN upload.
svn_uploadunconditionally ransvn mkdirwithcheck=True. If a prior run partially uploaded (dir created, some files imported) a re-run aborted onsvn mkdir('directory already exists'). Now a pre-existing RC directory is tolerated so the re-run resumes importing the remaining files. (This is exactly what happened with contrib RC1, which uploaded only 2 of 6 files.)scripts/verify-sub-packages/*.sh(all 4)The functional-verification step does
cd /tmp(so the local hamilton checkout doesn't shadow venv-installed packages via''onsys.path), but then referenced$ARTIFACTS_DIRrelatively — breaking when a relative local artifacts dir was passed (e.g.verify_sdk.sh 0.9.0 1 ui/sdk/dist):Now
ARTIFACTS_DIRis resolved to an absolute path right after acquisition.Verification
All four verify scripts were re-run end-to-end against the live SVN RC1 artifacts after these fixes and passed (GPG, SHA512, RAT, build-from-source, functional).