WIP: feat(icon): Support OS26 icon composer bundles#1568
Draft
dpogue wants to merge 1 commit intoapache:masterfrom
Draft
WIP: feat(icon): Support OS26 icon composer bundles#1568dpogue wants to merge 1 commit intoapache:masterfrom
dpogue wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1568 +/- ##
==========================================
+ Coverage 80.17% 80.22% +0.04%
==========================================
Files 18 18
Lines 5251 5279 +28
==========================================
+ Hits 4210 4235 +25
- Misses 1041 1044 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dpogue
force-pushed
the
feat-icon-support
branch
from
6106c3d to
c3753f2
Compare
breautek
reviewed
Apr 22, 2026
| if (!isAtLeastXcode26) { | ||
| events.emit('warning', `Xcode ${xcodeversion} cannot support icon: ${icon.src}. Skipping...`); | ||
| } else if (icon.height || icon.width) { | ||
| events.emit('warning', `Cannot specify height or width attributes with Icon Composer icon ${icon.src}. Skipping...`); |
Contributor
There was a problem hiding this comment.
instead of skipping the icon composor, would it just make sense to ignore the icon height & width (and provide a warning stating that height and weight has no effect on icon composer resources)?
| } else if (icon.height || icon.width) { | ||
| events.emit('warning', `Cannot specify height or width attributes with Icon Composer icon ${icon.src}. Skipping...`); | ||
| } else if (icon.target) { | ||
| events.emit('warning', `Cannot specify target attribute with Icon Composer icon ${icon.src}. Skipping...`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Xcode 26 and iOS 26 support a new
.iconbundle format from Icon Composer.Description
Check for icon definitions that have a
.iconextension and copy them into the project as resources.Remaining Work
Testing
Tested manually in an Xcode 26 project.
Checklist