Skip to content

doc: improve documentation of onRequestPermissionResult and onRequestPermissionsResult#1920

Open
GitToTheHub wants to merge 2 commits intomasterfrom
pr-doc-onRequestPermissionResult-and-onRequestPermissionsResult
Open

doc: improve documentation of onRequestPermissionResult and onRequestPermissionsResult#1920
GitToTheHub wants to merge 2 commits intomasterfrom
pr-doc-onRequestPermissionResult-and-onRequestPermissionsResult

Conversation

@GitToTheHub
Copy link
Copy Markdown
Contributor

Platforms affected

Android

Motivation and Context

  • Make clear, that these methods are not only called, when the user grants permissions, but also when he denies them or the request was interrupted.
  • Add note, how the call chain ist
  • Make clear, that onRequestPermissionResult is legacy and should not be used anymore
  • Add Android Developer documentation link for the new onRequestPermissionsResult

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

…estPermissionsResult`

- Make clear, that these methods are not only called, when the user grants permissions, but also when he denies them or the request was interrupted.
- Add note, how the call chain ist
- Make clear, that `onRequestPermissionResult` is legacy and should not be used anymore
- Add Android Developer documentation link for the new `onRequestPermissionsResult`
- Forgot to commit everything
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.43%. Comparing base (2450217) to head (869e685).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1920   +/-   ##
=======================================
  Coverage   61.43%   61.43%           
=======================================
  Files          24       24           
  Lines        4922     4922           
=======================================
  Hits         3024     3024           
  Misses       1898     1898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants