RFC2231Utils decodeText - Incorrect handling of percent encoded text#472
Open
Chenjp wants to merge 3 commits into
Open
RFC2231Utils decodeText - Incorrect handling of percent encoded text#472Chenjp wants to merge 3 commits into
Chenjp wants to merge 3 commits into
Conversation
Issue:
utf-8''%3\u8a35 -> 5
Expectation: illegal format.
raise iae when decode '%3\u8a35'.
garydgregory
requested changes
May 21, 2026
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
@Chenjp
Your PR breaks the build. Please test before you push, otherwise you're wasting our time and resources.
Author
😳sigh... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: decoded text does not conform rfc2231 was incorrectly decoded, e.g.,
utf-8''%3\u8a35->5Expectation: illegal format.
Code change: check the next 2 chars after percent %, ensure %HH format per RFC 2231, raise iae if not.
Testcase attached.