Skip to content

fix: recover terminal reattach after daemon idle#354

Merged
Vaibhaav-Tiwari merged 10 commits into
mainfrom
fix-terminal-daemon-reattach
Jun 21, 2026
Merged

fix: recover terminal reattach after daemon idle#354
Vaibhaav-Tiwari merged 10 commits into
mainfrom
fix-terminal-daemon-reattach

Conversation

@Vaibhaav-Tiwari

Copy link
Copy Markdown
Collaborator

Summary

  • add daemon identity to health/readiness probes so Electron can reject stale daemons from another checkout
  • have Electron inspect and re-adopt a compatible existing daemon instead of staying on stale status
  • refresh renderer daemon status while non-ready and gate terminal attach on daemon readiness

Closes #350

Tests

  • cd backend; go test ./internal/httpd ./internal/cli
  • cd frontend; pnpm.cmd run typecheck
  • cd frontend; pnpm.cmd run test src/renderer/hooks/useTerminalSession.test.tsx src/renderer/hooks/useDaemonStatus.test.tsx

@Vaibhaav-Tiwari Vaibhaav-Tiwari requested a review from Copilot June 20, 2026 22:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Vaibhaav-Tiwari Vaibhaav-Tiwari merged commit 708ec5d into main Jun 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal can stay stuck reattaching after daemon/session idle

2 participants