Harden CDP page target creation#382
Open
sk8erboi17 wants to merge 2 commits into
Open
Conversation
Add retries, CDP error reporting, and a DevTools HTTP fallback when Chrome does not return a page target id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome/CDP can occasionally fail to return a
targetIdafterTarget.createTarget, causing the web tool to stop with the generic errorChrome did not return a page target id`.This patch makes tab creation more robust by retrying
Target.createTarget, surfacing the real CDP error when available, and falling back to DevTools HTTP/json/newbefore failing.