fix: omniverse logging and stability#666
Open
david-bremer wants to merge 2 commits into
Open
Conversation
…rom the tmp file instead of stdout. Trap an exception thrown if the text following AWP_ROOT is not an int. An exception is being thrown when launched by a proc that sets AWP_ROOTDIR271.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The find_app() function, which looks for AWP_ROOT[ver] does not handle a non-integer following AWP_ROOT, such as AWP_ROOTDIR271. An exception is thrown, and uncaught by verify_showcase(), ultimately causing F1 to fail to start. The fix for this is on line 371-375.
https://tfs.ansys.com:8443/tfs/ANSYS_Development/Portfolio/_workitems/edit/1461766
I also started opening a file in $TMP to which Showcase output is written. The monitoring thread, that watched Showcase's stdout/err now reads the file to determine launch progress and get the simba URL.