Skip to content

fix(tools): fix NULL pointer dereference in output_fname allocation and set output_fname to NULL after freeing to prevent dangling pointer #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vahagavagyan wants to merge 2 commits into
base: amd-fftw
Choose a base branch
from
Open

fix(tools): fix NULL pointer dereference in output_fname allocation and set output_fname to NULL after freeing to prevent dangling pointer #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a4be51
fix(tools): fix NULL pointer dereference in output_fname allocation
vahagavagyan May 28, 2026
c91739f
fix: set output_fname to NULL after freeing to prevent dangling pointer
vahagavagyan May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tools/fftw-wisdom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,14 +215,21 @@ int bench_main(int argc, char *argv[])
break;

case 'o':
if (output_fname)
if (output_fname){
bench_free(output_fname);

output_fname = NULL;
}
if (!strcmp(my_optarg, "-"))
output_fname = 0;
else {
output_fname = (char *) bench_malloc(sizeof(char) *
(strlen(my_optarg) + 1));

/* Check for allocation failure to prevent NULL pointer dereference */
if (!output_fname) {
fprintf(stderr, "fftw-wisdom: out of memory\n");
exit(EXIT_FAILURE);
}
strcpy(output_fname, my_optarg);
}
break;
Expand Down