Complete leave game retirement records#6
Open
amanzhola wants to merge 8 commits into
Open
Conversation
Test Results 1 files - 5 1 suites - 5 1m 14s ⏱️ +57s Results for commit ad4c2fc. ± Comparison against base commit 5ec48af. This pull request removes 106 and adds 52 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
antlas1
reviewed
Jun 10, 2026
Collaborator
There was a problem hiding this comment.
Не уверен что этот каталог нужен для финального задания спринта
antlas1
reviewed
Jun 10, 2026
|
|
||
| for (const auto& object : collected_objects) { | ||
| if (object.type < loot_type_values.size()) { | ||
| score += loot_type_values.at(object.type); |
Collaborator
There was a problem hiding this comment.
Попробуйте использовать более целенаправленные алгоритмы - std::accumulate и аналоги вместо простого цикла с действием. Это улучшает читаемость и позволяет создавать более эффективный код. См. подробности CppCoreGuidelines ES.1
antlas1
reviewed
Jun 10, 2026
|
|
||
| return response; | ||
|
|
||
| } catch (...) { |
Collaborator
There was a problem hiding this comment.
Уменьшите использование catch (...). Лучше перехватывать ожидаемый тип исключений, наследник от std::exception. См. рекомендации Boost
antlas1
reviewed
Jun 10, 2026
|
|
||
| return response; | ||
|
|
||
| } catch (...) { |
antlas1
reviewed
Jun 10, 2026
antlas1
left a comment
antlas1
left a comment
Collaborator
There was a problem hiding this comment.
Хорошая работа. Отметил небольшие замечания
- Use std::accumulate instead of manual score accumulation (CppCoreGuidelines ES.1) - Replace catch(...) with catch(const std::exception&) according to Boost recommendations - Keep README as helper documentation for navigating changes; it does not affect the solution code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented dog retirement by inactivity.
Added:
Autotests: 52 passed.