Skip to content

Fix: frame freezing on Windows (#2931)#3212

Open
awa-vr wants to merge 1 commit intoalvr-org:masterfrom
awa-vr:master
Open

Fix: frame freezing on Windows (#2931)#3212
awa-vr wants to merge 1 commit intoalvr-org:masterfrom
awa-vr:master

Conversation

@awa-vr
Copy link
Copy Markdown

@awa-vr awa-vr commented Feb 22, 2026

Fixes issue #2931 for Windows users.

This also fixes the issue for v20.14.1 (see this branch), so maybe a v20.14.2 to fix this issue before v21 comes out could be nice.

Copy link
Copy Markdown
Collaborator

@The-personified-devil The-personified-devil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmerp What's your take on this? Doesn't look like a good solution to me but if it works it works, maybe?

@awa-vr
Copy link
Copy Markdown
Author

awa-vr commented Apr 8, 2026

I mean to be fair the comment above the change was a todo. But I've been using it for about 3 months now without any new issues, and the frame freezing went away.

Also I've tried changing stuff more deeply related to vsync and stuff, but it either didn't work or made it worse.

@zmerp
Copy link
Copy Markdown
Member

zmerp commented Apr 11, 2026

The only reason I think this would fix freezing is if SteamVR started consistently taking more than 10ms to unlock the texture. I guess this happens when for some reason SteamVR always uses the same texture instead of cycling them in the swapchains (there might be some other issues with frame indices handling like Vixea previously reported). I think this PR should work, but I would like to see tested also a timeout of 50ms. 50ms is definitely above any normal frametime (even at 30fps), and it's smaller enough that it will not cause any unnecessary waiting during shutdown. if that doesn't work let's try 100ms. @awa-vr

@awa-vr
Copy link
Copy Markdown
Author

awa-vr commented Apr 13, 2026

I don't have a ton of time to test stuff now so it might take a bit of time to test different timeouts.

@zmerp
Copy link
Copy Markdown
Member

zmerp commented Apr 13, 2026

That's alright. Unfortunately I can't reproduce this issue myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants