fcplay/cplay: Improve information printout regarding to buffer configuration and track playback progression#36
Open
ujfalusi wants to merge 5 commits into
Open
Conversation
fcplay ignores the values set via -b and -f parameters, change the compress_open_and_prepare() to take these into account similarly as cplay does. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
The number of fragments is useful information of the buffer allocation. Print it out alongside of the buffer size. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
The code only printed out the buffer size which was passed as parameter - and ironically, it was ignored. Correct the code to print out the size of the allocated buffer. The number of fragments is useful information of the buffer allocation. Print it out alongside of the buffer size. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Add compress_print_playback_info() to centralize playback configuration logging shared by cplay and fcplay. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Pass file_count and file_idx to compress_print_playback_info() so multi-file playback can show the current track number in the log while single-file playback keeps the same output format. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix fcplay to take the buffer and fragments parameter into account (it is ignored currently)
Make the prints about buffer configuration more informative and common between cplay and fcplay
During multiple file playback with fcplay print out the new file when the changeover happens.