fix: rate-limiting interfering with old line cleanup#14
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where rate-limiting in the Step procedure was interfering with the cleanup of previously rendered status lines. The issue occurred because Old_Line was being calculated from the current state of the status set (after updates) rather than from what was actually last rendered to the screen.
Changes:
- Fixed
Stepprocedure to useLast_Status_Line(the last rendered status) instead ofBuild_Status_Line(current status set state) for cleanup - Bumped version from 3.0.0 to 3.0.1-dev to reflect the bug fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/simple_logging.adb | Changed line 303 to use To_String(Last_Status_Line) instead of This.Build_Status_Line to correctly track the previously rendered status line for cleanup when rate-limiting causes early returns |
| alire.toml | Bumped version from 3.0.0 to 3.0.1-dev to reflect the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.