1.21.1-NF: vault no longer cancels fast run#485
Open
erutobusiness wants to merge 1 commit into
Open
Conversation
When vaulting, vanilla Minecraft cancels the sprint state due to the horizontal block collision in the first 1-2 ticks of the vault animation. This causes FastRun.canContinue() to fail (it requires player.isSprinting()), stopping the fast run mid-vault. Register a sprint cancel marker in Vault.onStartInLocalClient so that the LivingEntityMixin setSprinting hook blocks vanilla's cancellation for the duration of the vault (marker remains while isDoing() is true). This follows the same pattern already used by RideZipline.
erutobusiness
changed the title
Owner
|
If I remember correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vaulting over obstacles cancels vanilla sprint due to horizontal block collision in the first couple ticks of the vault animation. Since FastRun.canContinue() requires player.isSprinting(), this caused fast run to stop mid-vault, leaving the player walking after the vault completes.
The fix registers a sprint cancel marker in Vault.onStartInLocalClient so that the LivingEntityMixin setSprinting hook blocks vanilla's cancellation for the duration of the vault. This is the same pattern already used by RideZipline.