Skip to content

fix(inkless): ensure ReplicaManager shutdown in Inkless tests#623

Open
jeqo wants to merge 1 commit into
mainfrom
jeqo/fix-replica-manager-test
Open

fix(inkless): ensure ReplicaManager shutdown in Inkless tests#623
jeqo wants to merge 1 commit into
mainfrom
jeqo/fix-replica-manager-test

Conversation

@jeqo
Copy link
Copy Markdown
Contributor

@jeqo jeqo commented May 29, 2026

Move replicaManager initialization outside try blocks so shutdown can be placed in finally, preventing executor-Fetch thread leaks that cause verifyNoUnexpectedThreads failures in CI nightly.

@jeqo
Copy link
Copy Markdown
Contributor Author

jeqo commented May 29, 2026

Running Nightly CI manually on this branch to check if it goes green again: https://github.com/aiven/inkless/actions/runs/26640104032

@jeqo jeqo force-pushed the jeqo/fix-replica-manager-test branch from c51f1b5 to 3754fec Compare May 29, 2026 13:56
@jeqo
Copy link
Copy Markdown
Contributor Author

jeqo commented May 29, 2026

Move replicaManager initialization outside try blocks so shutdown
can be placed in finally, preventing executor-Fetch thread leaks
that cause verifyNoUnexpectedThreads failures in CI nightly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jeqo jeqo force-pushed the jeqo/fix-replica-manager-test branch from 3754fec to 154914c Compare May 29, 2026 15:05
@jeqo
Copy link
Copy Markdown
Contributor Author

jeqo commented May 29, 2026

CI back to green, testing Nightly CI again: https://github.com/aiven/inkless/actions/runs/26646059681

@jeqo
Copy link
Copy Markdown
Contributor Author

jeqo commented May 29, 2026

Nightly CI is green again 🟢

@jeqo jeqo marked this pull request as ready for review May 29, 2026 16:38
@jeqo jeqo requested review from tvainika and viktorsomogyi May 29, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant