Giuseppelillo/diskless switch optimization#602
Draft
giuseppelillo wants to merge 5 commits into
Draft
Conversation
giuseppelillo
force-pushed
the
giuseppelillo/diskless-switch-optimization
branch
from
8e97476 to
476de41
Compare
giuseppelillo
force-pushed
the
giuseppelillo/rename-diskless-switch
branch
from
bd841fb to
17a898e
Compare
giuseppelillo
force-pushed
the
giuseppelillo/diskless-switch-optimization
branch
from
476de41 to
42cc584
Compare
giuseppelillo
force-pushed
the
giuseppelillo/rename-diskless-switch
branch
from
0591cb6 to
3990aeb
Compare
`seal()` is invoked from multiple paths (sealTopicPartitions, applyLocalLeadersDelta and applyLocalFollowersDelta) and is intentionally idempotent, but it always grabbed `leaderIsrUpdateLock` in write mode -- contending with the read lock taken on every append. Read the @volatile `_sealed` flag first and only take the lock on the first transition.
Rewrite `getClassicToDisklessStartOffset` to use nullable lookups instead of wrapping each step in `Option`, since this method is used on fetch and offset-listing paths.
Cache the diskless-topic decision in leader and follower transition loops and derive consolidating-diskless status from it. This avoids repeated topic config lookups while applying metadata deltas.
In the diskless follower transition path, test `seal >= 0` before calling `logManager.getLog`. Fully switched partitions can then skip the local-log map lookup entirely.
When a partition is already tracked, re-drive the existing state before creating a new WaitingForReplication listener. This keeps duplicate registrations cheap while preserving the existing re-evaluation behavior.
giuseppelillo
force-pushed
the
giuseppelillo/diskless-switch-optimization
branch
from
42cc584 to
24b8f00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete this text and replace it with a detailed description of your change. The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some commentary, upload images, or
include other supplemental information that should not be part of the eventual
commit message, please use a separate comment.
If applicable, please include a summary of the testing strategy (including
rationale) for the proposed change. Unit and/or integration tests are expected
for any behavior change and system tests should be considered for larger
changes.