Don't use K8s corev1.EnvVar#137
Merged
Merged
Conversation
|
I already do this in #20? |
Davanum Srinivas (dims)
approved these changes
Jun 2, 2026
Collaborator
Author
I think there's still some points of discussion happening on your env secrets PR, and I wanted to make sure that we remove this type ASAP. Apologies for the churn. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActorTemplate should not refer directly to a K8s type, although we want to keep the same shape of the API for features we support. Define an equivalent EnvVar that only has the things we currently support.