Update/verify dep vendoring#132
Conversation
yes please! |
Tim Hockin (thockin)
force-pushed
the
add-vendoring
branch
from
78740f8 to
2d2c34a
Compare
|
Now vendors all go.mod directories |
Tim Hockin (thockin)
force-pushed
the
add-vendoring
branch
from
2d2c34a to
4785e85
Compare
|
I broke up the large commits into script-changes and run-the-script commits. the "run" commits are just the output of running the script. |
Davanum Srinivas (dims)
left a comment
Davanum Srinivas (dims)
left a comment
There was a problem hiding this comment.
LGTM
the individual vendor/ for each tool ... we'll get used to it.
I cannot say why this removed go code from within LICENSES (GOROOT, I guess?) or why that code was there in the first place. The GOROOT change is needed when the compiler in use doesn't match the go env, causing it to flag stdlib as "not a module".
|
rebased |
Tim Hockin (thockin)
force-pushed
the
add-vendoring
branch
from
4785e85 to
f9e50be
Compare
I'm not convinced. That adds a LOT more bloat, and reviewing tools-module vendor is not nearly as actionable. We're using go mod as an implementation detail of obtaining those tools, we could just as well fetch binaries. |
|
Also, we shouldn't be dropping anything from LICENSES here, what's going on there? |
| @@ -1,27 +0,0 @@ | |||
| // +build windows solaris | |||
There was a problem hiding this comment.
The code in LICENSES was here because the library is MPL and requires redistributing the sources. I think this commit broke something.
|
Github won't show me the full diff, even commit by commit. |
|
Benjamin Elder (@BenTheElder) i switched to |
3 participants
This adds an update/verify script pair to check
go mod vendorin the main module. Should we do this in sub-modules too?Fixes #19