Skip to content

chore: sync core lib and CLAUDE.md from agent-core#32

Merged
avifenesh merged 1 commit into
mainfrom
chore/sync-core-perf-20260530-093141
May 30, 2026
Merged

chore: sync core lib and CLAUDE.md from agent-core#32
avifenesh merged 1 commit into
mainfrom
chore/sync-core-perf-20260530-093141

Conversation

@avifenesh
Copy link
Copy Markdown
Contributor

Automated sync of lib/ and CLAUDE.md from agent-core.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances file operations across several modules to prevent Time-of-Check to Time-of-Use (TOCTOU) race conditions. It introduces a safe file-reading utility, readFileWithLimit, which performs type and size checks on a single file descriptor, and adopts atomic writes for file updates. Feedback on these changes suggests adding a fallback check in lib/patterns/slop-analyzers.js where fs.openSync is used directly, ensuring compatibility with mock file systems in unit tests that may not implement this method.

Comment thread lib/patterns/slop-analyzers.js
@avifenesh
Copy link
Copy Markdown
Contributor Author

This is an auto-sync of the already-reviewed agent-core fix (PR agent-sh/agent-core#25). The auto-reviewer's symlink/TOCTOU notes are addressed by the design: reads use the fd-based readFileWithLimit, and writes use writeFileAtomic (temp file + atomic rename). rename() replaces the path entry itself and never follows a symlink to its target, so it is symlink-safe by construction - the explicit assertNotSymlink in fixer.js is belt-and-suspenders for that path. Merging to keep lib in sync with the source.

@avifenesh avifenesh merged commit 9ade492 into main May 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant