Add per-resource authority checks to typed CRUD and batch providers#2603
Merged
johngrimes merged 1 commit intomainfrom May 9, 2026
Merged
Add per-resource authority checks to typed CRUD and batch providers#2603johngrimes merged 1 commit intomainfrom
johngrimes merged 1 commit intomainfrom
Conversation
Typed FHIR resource providers (Search, Read, Create, Update, Delete) and the Batch provider previously only enforced operation-level authorities (e.g. pathling:search, pathling:update) but did not check per-resource read/write authority. This allowed a caller with a coarse-grained token to access any resource type. Adds explicit SecurityAspect.checkHasAuthority() calls gated by auth.enabled to each provider method, and injects ServerConfiguration into the providers and their factories that lacked it. Includes focused auth unit tests for all six providers.
|
johngrimes
added
bug
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typed FHIR resource providers (Search, Read, Create, Update, Delete) and the Batch provider previously only enforced operation-level authorities (e.g.
pathling:search,pathling:update) but did not check per-resource read/write authority. This allowed a caller with a coarse-grained token to access any resource type.Adds explicit
SecurityAspect.checkHasAuthority()calls gated byauth.enabledto each provider method, and injectsServerConfigurationinto the providers and their factories that lacked it.Includes focused auth unit tests for all six providers.