Skip to content

feat: Skip the Kalman filter on the first CKF step#1310

Open
niermann999 wants to merge 3 commits intoacts-project:mainfrom
niermann999:feat-skip-first-meas-KF
Open

feat: Skip the Kalman filter on the first CKF step#1310
niermann999 wants to merge 3 commits intoacts-project:mainfrom
niermann999:feat-skip-first-meas-KF

Conversation

@niermann999
Copy link
Copy Markdown
Contributor

@niermann999 niermann999 commented May 5, 2026

No need to run the KF on the first measurement, since it is the initial information that the KF is started with

@niermann999 niermann999 force-pushed the feat-skip-first-meas-KF branch 2 times, most recently from 2e1c02d to 806e1a0 Compare May 5, 2026 18:07
@niermann999 niermann999 changed the title feat: Skip the Kalman fitter on the first CKF step feat: Skip the Kalman filter on the first CKF step May 5, 2026
@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 force-pushed the feat-skip-first-meas-KF branch from 806e1a0 to 8dc9229 Compare May 5, 2026 18:25
@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 added the performance Performance-relevant changes label May 6, 2026
@niermann999 niermann999 force-pushed the feat-skip-first-meas-KF branch 2 times, most recently from dc86444 to 3b697b3 Compare May 7, 2026 08:48
@niermann999 niermann999 force-pushed the feat-skip-first-meas-KF branch from 3b697b3 to 784e970 Compare May 7, 2026 13:23
@stephenswat
Copy link
Copy Markdown
Member

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --conditions-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298341 to 298341 (+0.0%)

Seeding plots



Track finding performance

Total number of found tracks went from 50211 to 50211 (+0.0%)

Finding plots









Track fitting performance

Fitting plots














Seeding to track finding relative performance

Seeding to track finding plots



Note

This is an automated message produced on the explicit request of a human being.

@niermann999 niermann999 force-pushed the feat-skip-first-meas-KF branch from 784e970 to 1b06bad Compare May 7, 2026 13:38
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@stephenswat
Copy link
Copy Markdown
Member

Performance summary

Here is a summary of the performance effects of this PR:

Graphical

Tabular

KernelReciprocal ThroughputParallelism
bd18c46784e970Deltabd18c46784e970
propagate_to_next_surface5.80 ms5.80 ms-0.0%4.334.34
find_tracks1.76 ms1.76 ms-0.5%1.831.67
count_doublets816.16 μs809.72 μs-0.8%1.611.61
ccl_kernel592.59 μs593.12 μs0.1%1.711.71
count_triplets568.65 μs568.06 μs-0.1%1.021.02
find_doublets534.08 μs533.39 μs-0.1%3.083.08
Thrust::sort379.96 μs378.51 μs-0.4%7.327.32
find_triplets169.56 μs169.47 μs-0.1%1.321.31
estimate_track_params146.49 μs146.71 μs0.2%2.682.68
build_tracks123.82 μs123.39 μs-0.3%3.713.71
select_seeds59.83 μs60.01 μs0.3%1.341.34
populate_grid24.02 μs23.97 μs-0.2%1.221.22
count_grid_capacities22.21 μs22.15 μs-0.3%1.221.22
remove_duplicates20.12 μs20.13 μs0.0%25.5625.54
fill_sorted_measurements17.94 μs17.60 μs-1.9%1.131.13
update_triplet_weights16.47 μs16.33 μs-0.9%1.271.27
fill_finding_propagation_sort_keys9.65 μs9.62 μs-0.3%7.377.55
form_spacepoints8.63 μs8.52 μs-1.2%1.481.48
reduce_triplet_counts5.66 μs5.70 μs0.7%3.083.08
unknown5.08 μs5.07 μs-0.4%4.274.29
fill_finding_duplicate_removal_sort_keys1.59 μs1.58 μs-1.0%38.8237.74
Total11.09 ms11.07 ms-0.2%3.393.37

Important

All metrics in this report are given as reciprocal throughput, not as wallclock runtime.

Note

This is an automated message produced upon the explicit request of a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance-relevant changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants