Skip to content

feat: Add search bar for DataTable#693

Merged
aXenDeveloper merged 2 commits into
canaryfrom
feat/search_data_table
Jun 3, 2026
Merged

feat: Add search bar for DataTable#693
aXenDeveloper merged 2 commits into
canaryfrom
feat/search_data_table

Conversation

@aXenDeveloper
Copy link
Copy Markdown
Owner

Improving Documentation

Description

What?

Why?

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vitnode-docs Ready Ready Preview, Comment Jun 3, 2026 5:36pm

@github-actions github-actions Bot added the 💡 Feature A new feature label Jun 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a type-safe, full-text-like search feature integrated with VitNode's cursor-based pagination and DataTable component. Key changes include updating the withPagination helper to support case-insensitive ILIKE search across specified columns, adding a debounced SearchDataTable input component, and updating documentation and locales. Feedback on these changes highlights an out-of-sync bug in the search input where typing fewer than three characters fails to clear the active search from the URL, as well as a recommendation to set type='search' on the input for better mobile accessibility.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/vitnode/src/components/table/search.tsx
Comment thread packages/vitnode/src/components/table/search.tsx
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9d0a4a2468

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/vitnode/src/components/table/search.tsx
Comment thread packages/vitnode/src/components/table/search.tsx Outdated
@aXenDeveloper aXenDeveloper merged commit cbcc5a1 into canary Jun 3, 2026
4 checks passed
@aXenDeveloper aXenDeveloper deleted the feat/search_data_table branch June 3, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💡 Feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant