fix(base-query): only register in objectByClass when type opts in via @Indexable#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Indexableguard onobjectByClassentirely, causing every indexed object to be registered in class-membership regardless of whether its class declared any indexable fields. The correct rule is: a type participates in class-membership if it carries@Indexableat the class level or has at least one@Indexablefunction field.objectByClassis now populated after the function-map loops inindex(), and removed after the function-map loops inunindex(), so that a thrown exception during function processing leavesobjectByClassin a consistent state — the two methods are now symmetric.IndexCompatibilityTests: plain types (no@Indexableanywhere) are excluded from class-membership; function-field-only types are included; and a failedindex()call leavesobjectByClassclean.