Fix cursor x-position on empty lines with first-line indent#15
Merged
Conversation
The empty-line indent workaround in `calculateCursorPosition` only covered line-block paragraph styles (bullet, blockquote, list, code fence). When the editor's own `textStyle.textIndent.firstLine` was set, the cursor still sat at `x=0` on an empty line and visibly snapped to the indent the moment the user typed the first character. Generalize the fix to fall back to the editor-wide `textStyle.textIndent` when no line-block is attached. Block-line indent still takes precedence since `updateBookKeeping` doesn't bake the editor-wide indent onto lines that already carry a `ParagraphStyle`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The empty-line indent workaround in
calculateCursorPositiononlycovered line-block paragraph styles (bullet, blockquote, list, code
fence). When the editor's own
textStyle.textIndent.firstLinewas set,the cursor still sat at
x=0on an empty line and visibly snapped tothe indent the moment the user typed the first character.
Generalize the fix to fall back to the editor-wide
textStyle.textIndentwhen no line-block is attached. Block-line indent still takes precedence
since
updateBookKeepingdoesn't bake the editor-wide indent onto linesthat already carry a
ParagraphStyle.