Preperations for block containment checking conversion#782
Open
Atdit wants to merge 1 commit intoWarzoneMC:masterfrom
Open
Preperations for block containment checking conversion#782Atdit wants to merge 1 commit intoWarzoneMC:masterfrom
Atdit wants to merge 1 commit intoWarzoneMC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes do not change any game mechanics at all, but will be necessary for the upcoming block containment checking conversion from block positions to coordinates. It will make the final conversion PR a lot more smaller and readable. For the conversion to take effect after this PR, the only changes left have to be done in the individual Region.contains(Block block) methods.
Tested.
Important note: I made changes to the cylinder/(hemi)sphere classes getBlocks() methods to remove redundant code, however, I'm unsure if there was an actual intention behind that code. The only usage for getBlocks() is found in portals, which I tested and still worked.