Merge: Cleanup apis

Author: CouleeApps

binaryninjaapi.h

@@ -22401,7 +22401,6 @@ namespace BinaryNinja {
 	{
 	public:
 		explicit DatabaseObject(BNDatabaseObject* database);
-		virtual ~DatabaseObject();
 
 		// TODO: User subclassing
 		int GetType() const;
@@ -22419,7 +22418,6 @@ namespace BinaryNinja {
 	public:
 		explicit DiffState(BNDiffState* state);
 		explicit DiffState(Ref<Logger> logger);
-		virtual ~DiffState();
 
 		std::vector<std::string> GetErrors() const;
 		void ClearErrors();
@@ -22447,7 +22445,6 @@ namespace BinaryNinja {
 	{
 	public:
 		DiffObject(BNDiffObject* object);
-		virtual ~DiffObject();
 
 		std::optional<std::string> GetBase() const;
 		std::optional<std::string> GetLeft() const;

merge.cpp

@@ -30,10 +30,6 @@ DatabaseObject::DatabaseObject(BNDatabaseObject* object)
 }
 
 
-// todo: this can be deleted
-DatabaseObject::~DatabaseObject() = default;
-
-
 Ref<DatabaseObject> DatabaseObject::GetParent() const
 {
 	BNDatabaseObject* parent = BNGetDatabaseObjectParent(m_object);
@@ -125,10 +121,6 @@ DiffState::DiffState(Ref<Logger> logger)
 }
 
 
-// todo: this can be deleted
-DiffState::~DiffState() = default;
-
-
 std::vector<std::string> DiffState::GetErrors() const
 {
 	size_t count = 0;
@@ -203,10 +195,6 @@ DiffObject::DiffObject(BNDiffObject* object)
 }
 
 
-// todo: this can be deleted
-DiffObject::~DiffObject() = default;
-
-
 std::optional<std::string> DiffObject::GetBase() const
 {
 	char* base = BNGetDiffObjectBase(m_object);