@@ -30,6 +30,7 @@ DatabaseObject::DatabaseObject(BNDatabaseObject* object)
3030}
3131
3232
33+ // todo: this can be deleted
3334DatabaseObject::~DatabaseObject () = default ;
3435
3536
@@ -85,6 +86,8 @@ std::unordered_map<std::string, Ref<DatabaseObject>> DatabaseObject::GetChildren
8586 BNDatabaseObject** objects;
8687 size_t count = BNGetDatabaseObjectChildren (m_object, &names, &objects);
8788
89+ // todo: do we want a cache?
90+
8891 std::unordered_map<std::string, Ref<DatabaseObject>> result;
8992 for (size_t i = 0 ; i < count; i++)
9093 {
@@ -97,6 +100,9 @@ std::unordered_map<std::string, Ref<DatabaseObject>> DatabaseObject::GetChildren
97100}
98101
99102
103+ // todo: expose GetChild() and friends
104+
105+
100106std::vector<std::string> DatabaseObject::GetDependencies () const
101107{
102108 size_t count = 0 ;
@@ -119,6 +125,7 @@ DiffState::DiffState(Ref<Logger> logger)
119125}
120126
121127
128+ // todo: this can be deleted
122129DiffState::~DiffState () = default ;
123130
124131
@@ -196,6 +203,7 @@ DiffObject::DiffObject(BNDiffObject* object)
196203}
197204
198205
206+ // todo: this can be deleted
199207DiffObject::~DiffObject () = default ;
200208
201209
@@ -244,6 +252,8 @@ std::unordered_map<std::string, Ref<DiffObject>> DiffObject::GetChildren() const
244252 BNDiffObject** objects;
245253 size_t count = BNGetDiffObjectChildren (m_object, &names, &objects);
246254
255+ // todo: do we want a cache?
256+
247257 std::unordered_map<std::string, Ref<DiffObject>> result;
248258 for (size_t i = 0 ; i < count; i++)
249259 {
0 commit comments